This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Update to prevent some compiler warnings #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
suggested changes
Feb 10, 2017
src/lib/mqtt.cpp
Outdated
| @@ -15,7 +15,7 @@ MQTT::MQTT(ESP *esp8266) | |||
| boolean MQTT::begin(const char* client_id, const char* user, const char* pass, uint16_t keep_alive, boolean clean_seasion) | |||
| { | |||
| uint16_t crc; | |||
| uint32_t wait, cb_data; | |||
| uint32_t /*wait,*/ cb_data; | |||
There was a problem hiding this comment.
Is wait unused everywhere or only in this implementation?
src/lib/CiaoData.h
Outdated
| return msg_split[index]; | ||
| } | ||
|
|
||
| bool isEmpty(){ | ||
| //if (atoi( get(1) ) > 0) | ||
| if (get(2) != "") | ||
| //if (get(2) != "") | ||
| if ( strcmp(get(2), "") != 0) |
There was a problem hiding this comment.
strcmp is unsafe, it's better if you use strncmp (or something even easier, based on what is the expected result of get(2))
src/UnoWiFiDevEd.h
Outdated
| @@ -30,11 +30,31 @@ class ArduinoWifiClass : public WifiData | |||
|
|
|||
| class CiaoClass : public WifiData | |||
| { | |||
| private: | |||
| const char* DEF_DATA = ""; | |||
| const char* DEF_METH = "GET"; | |||
There was a problem hiding this comment.
Are these strings hidden as defines really needed?
| @@ -239,8 +224,13 @@ CiaoData PassThroughWrite(char* connector,char* hostname, String data, char* met | |||
| ciao_data.msg_split[2]="Protocol Error"; | |||
| return ciao_data; | |||
| } | |||
| } | |||
|
|
|||
| CiaoData PassThroughWrite(const char* connector, const char* hostname, String data, const char* method){ | |||
upd: update examples upd: code review
sergiotomasello
force-pushed
the
master
branch
from
ba54c7f
to
9e81558
Compare
facchinm
approved these changes
Feb 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.