Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for command line man page #3470

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Conversation

pfeerick
Copy link
Contributor

@pfeerick pfeerick commented Jul 6, 2015

Amendment to CLI documentation re: Windows GUI/console executable differences and behaviours, as per #3461, unless it is expected to change in the near future...

Amendment to CLI documentation re: Windows GUI/console executable differences and behaviours, as per arduino#3461, unless it is expected to change in the near future...
@pfeerick
Copy link
Contributor Author

pfeerick commented Jul 6, 2015

Apologies if this could have somehow been incorporated in to #3461... I'm still a noob with Git(hub)... but I try (and I am very trying! ;)

@matthijskooijman
Copy link
Collaborator

Thanks for the pull-request, it looks ready to merge to me.

As for including this in the issue you reported - that's not possible, PRs and issues are separate things (you can add more commits to a PR after submitting it, but you cannot add commits to an issue).

@ffissore ffissore added the Component: Documentation Related to Arduino's documentation content label Jul 6, 2015
@ffissore ffissore added this to the Release 1.6.6 milestone Jul 6, 2015
@ffissore ffissore self-assigned this Jul 6, 2015
ffissore added a commit that referenced this pull request Jul 6, 2015
Update for command line man page
@ffissore ffissore merged commit 31a5b02 into arduino:master Jul 6, 2015
@ffissore
Copy link
Contributor

ffissore commented Jul 6, 2015

Thanks!

@pfeerick
Copy link
Contributor Author

pfeerick commented Jul 6, 2015

No problem @ffissore. I like to help where I can :) And thanks @matthijskooijman I couldn't see anything in the issue that would let me do it so I just forked and PR'd the change. I've played with git repos for tracking personal code, but haven't forked or PR'd before, so that was interesting!!

@pfeerick pfeerick deleted the patch-1 branch July 6, 2015 09:18
@matthijskooijman
Copy link
Collaborator

Well, be sure to practice your pull-request skills whenever you have a chance :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Related to Arduino's documentation content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants