Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-platform keywords.txt #3847

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

PaulStoffregen
Copy link
Sponsor Contributor

This patch allows platforms to define an keywords.txt file, to add their unique keywords. When a board change also changes platforms, the keywords are reloaded and all editor windows updates with the new keywords.

@NicoHood
Copy link
Contributor

Would this also fix #2996 ?

@PaulStoffregen
Copy link
Sponsor Contributor Author

Yes, I believe it should partially fix #2996.

The keywords are only re-read when changing architecture folders. If you have a AVR board which uses hardware/arduino/avr for its boards.txt and platform.txt and you switch to a different board, keywords will not be re-read if the new board also uses hardware/arduino/avr. But if you switch to a board that uses hardware/HoodLoader2/avr as its boards.txt and platform.txt, then keywords will be re-read.

Any chance you could give the arduinobot build a quick try? Would be nice if someone (other than me) could at least confirm it works in at least 1 quick test...

@NicoHood
Copy link
Contributor

The specific issue I linked is fixed with this.

@PaulStoffregen
Copy link
Sponsor Contributor Author

Good :)

Is the assumption correct that keywords only need to be re-read when a board change switches to a new architecture folder? Are there any cases where this would be needed changing between boards that share the same architecture folder?

@ffissore ffissore self-assigned this Sep 28, 2015
@NicoHood
Copy link
Contributor

I think the behavior is correct like this. I havent looked at the patch itself but from the logic you described it is correct, no need for a further change.

@lmihalkovic
Copy link

[LMNTS]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants