Quote linker script path in compilation recipe #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unquoted path to the linker script caused compilation to fail when the temporary build folder path contained spaces: ``` $ arduino-cli compile --fqbn arduino:mbed_portenta:envie_m7 --build-path "/tmp/some path with spaces" arm-none-eabi-g++: error: path: No such file or directory arm-none-eabi-g++: error: with: No such file or directory arm-none-eabi-g++: error: spaces/linker_script.ld: No such file or directory ```
|
Memory usage change @ 07749a4
Click for full report table
Click for full report CSV |
|
Thanks a lot for spotting this @per1234 ! Do you think it makes sense to make a new release immediately? How many users do you think are currently affected? |
A search for the error message only returns one report. I believe @jhansson-ard was also affected. So that's a total of two affected users that I am aware of, over the course of the ~7 days since it was released. |
|
I can confirm the fix is working on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unquoted path to the linker script caused compilation to fail when the temporary build folder path contained spaces:
The above demo uses Arduino CLI as an easy way to guarantee the build path has spaces, but this bug affects users of all Arduino development software with a space in their temporary folder path (e.g., Windows users with a space in their user name) under normal conditions.