Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global platform.txt #469

Closed
fabianoriccardi opened this issue Oct 29, 2019 · 2 comments · Fixed by #472
Closed

Global platform.txt #469

fabianoriccardi opened this issue Oct 29, 2019 · 2 comments · Fixed by #472
Assignees
@cmaglie

Comments

@fabianoriccardi
Copy link

Hi all,
I was using the global platform.txt, (the one stored at path/to/your/app/hardware/platform.txt) to execute some custom prebuild hooks. I was working until I updated to Arduino IDE version 1.8.10. I switched back to version 1.8.9 and the hooks work as usual. Is it changed something in Arduino toolchain management?
@facchinm
Copy link
Member

@cmaglie I think this is related with the switch of arduino-builder to CLI
@fabiuz7 can you provide here the exact setting you were overriding and the expected result? Thanks!

@fabianoriccardi
Copy link
Author

Actually I used that file for the following configuration:

recipe.hooks.sketch.prebuild.1.pattern=git-version.bat {build.source.path}/src {build.path}/sketch/src

Which is a small script to embed GIT tag in source code. More detail

I can observe that this script is never run.

@cmaglie cmaglie transferred this issue from arduino/Arduino Nov 4, 2019
cmaglie added a commit that referenced this issue Nov 6, 2019
@cmaglie
Builder allows loading of global user-customizable platform.txt
3c1cda2 
Fix #469
@cmaglie cmaglie mentioned this issue Nov 7, 2019
Merged
cmaglie added a commit that referenced this issue Nov 8, 2019
@cmaglie
Builder allows loading of global user-customizable platform.txt
d28d833 
Fix #469
cmaglie added a commit that referenced this issue Nov 8, 2019
@cmaglie
Allow loading of global user-customizable platform.txt (#472)
bc6c823 
Fix #469
cmaglie added a commit to arduino/arduino-builder that referenced this issue Nov 8, 2019
@cmaglie
Multiple upstream fix
f5af1e9 
- Allow loading of global user-define platform.txt
(arduino/arduino-cli#469)

- Fixed nil pointer exception on some rare case with
  multiple libs selection
(arduino/arduino-cli#477)

Fix #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-allow global user-customizable platform.txt arduino/arduino-cli
3 participants
@cmaglie @fabianoriccardi @facchinm