Skip dependency detection if library is fully precompiled #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precompiled bits of a library should not depend on any link time dependency (we cannot assure ABI stability). Fixes arduino/ArduinoCore-mbed#119
silvanocerza
force-pushed
the
skip_dependency_detection_precompiled
branch
from
48f98c4
to
4fba67b
Compare
|
I rebased the PR on top of |
cmaglie
approved these changes
Jan 26, 2021
silvanocerza
added a commit
that referenced
this pull request
Jan 27, 2021
* Skip dependency detection if library is fully precompiled Precompiled bits of a library should not depend on any link time dependency (we cannot assure ABI stability). Fixes arduino/ArduinoCore-mbed#119 * Add output when skipping deps detection for precompiled libs Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompiled bits of a library should not depend on any link time dependency (we cannot assure ABI stability).
Fixes arduino/ArduinoCore-mbed#119
tests will be added tomorrow on
arduino-cli/test/test_compile.py
Line 185 in c30031b
@rsora @cmaglie
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)titled accordingly?
See how to contribute