Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib list --all not returning library includes in json output #1147

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a regression when calling lib list.

  • What is the current behavior?

lib list --all --fqbn arduino:avr:uno --format json doesn't return the provides_includes property for the libraries installed together with the specified core, arduino:avr in this case.

If the includes property found in the library.properties file is empty we would return nothing.

  • What is the new behavior?

lib list --all --fqbn arduino:avr:uno --format json now correctly return provides_includes property for all libraries.

Now if the includes property in the library.properties file is empty we walk the library's folders to gather the headers file names.

Nope.

  • Other information:

None.


See how to contribute

test/test_lib.py Outdated Show resolved Hide resolved
test/test_lib.py Show resolved Hide resolved
@silvanocerza silvanocerza merged commit d996b15 into master Jan 22, 2021
@silvanocerza silvanocerza deleted the scerza/fix-lib-list-all-includes branch January 22, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants