Add back support for sketches with .pde extension and deprecate it #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
requested changes
Jan 28, 2021
Comment on lines
130
to
+139
| sketchPath := initSketchPath(path) | ||
|
|
||
| // .pde files are still supported but deprecated, this warning urges the user to rename them | ||
| if files := sketches.CheckForPdeFiles(sketchPath); len(files) > 0 { | ||
| feedback.Error("Sketches with .pde extension are deprecated, please rename the following files to .ino:") | ||
| for _, f := range files { | ||
| feedback.Error(f) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This piece is duplicated in compile.go, upload.go and archive.go.
On compile.go and upload.go there is also initSketchPath() that is duplicated as well.
This makes me wonder two things:
- in archive.go we are missing some cases because we miss an
initSketchPath(...) - we must move everything (the current initSketchPath and the pde check) into a common function
args.InitSketchParh(path)or something like that...
There was a problem hiding this comment.
This is probably something that we need to tackle in a systematic way and not in this PR or it would make it explode.
silvanocerza
force-pushed
the
scerza/pde-support
branch
from
c9d5f7e
to
b105981
Compare
silvanocerza
force-pushed
the
scerza/pde-support
branch
from
b105981
to
686d3f8
Compare
cmaglie
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This PR brings back the support for sketches ending with
.pdeextension.Also we deprecate it.
Trying to
compile,upload, orarchivea sketch with a.pdemain file always fails.Also examples' libraries with
.pdeextensions are not shown when callinglib examples.compile,upload, orarchivea sketch with a.pdemain file now works correctly and shows a warning message recommending the user to rename all.pdefiles.ino.Examples' libraries with
.pdeextensions are now correctly shown when callinglib examples.No.
Each commit fixes a different command, it should be easier to review each commit separately.
See how to contribute