[skip changelog] Fix core commands skipping gRPC interface #1169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.md
has been updated with a migration guide (for breaking changes)Refactors some commands internals.
cli/core
commands are currently callingcommands/core
function without usingrpc
Requests structs.All
cli/core
commands now callcommands/core
functions using therpc
Requests structs.Nope.
We don't fix any issue with this PR but we'll avoid breaking the CLI and the gRPC interface alignment.
This adds more output to
core list --format json
but it doesn't break anything.This change started out from a comment by @cmaglie on #1166, we should rebase that branch on top of this and another subsequent PR that will fix some legacy tests to verify that hardware loading works as expected.
See how to contribute