Better detection of required serial port during upload. #1398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked the upload recipe for the variable
{serial.port}
to determine if the upload requires a serial port, but this is not sufficient because we must check also for the variable{serial.port.file}
.No breaking changes.
Current output:
As we can see the
bossac
tool is launched anyway with the unexpanded{serial.port.file}
variable.New behavior:
The message
No upload port found, using as fallback
can be still improved, but at least we have a clear indication that the error is caused byno upload port provided
.