Optimize core operations, improving on the user input
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
per1234
requested changes
Nov 29, 2021
cli/arguments/reference.go
Outdated
Comment on lines
40
to
44
| func ParseReferences(args []string, parseArch bool) ([]*Reference, error) { | ||
| func ParseReferences(args []string, inst *rpc.Instance) ([]*Reference, error) { |
There was a problem hiding this comment.
This is a breaking change to the public API, so it must be documented following the standard procedure:
https://arduino.github.io/arduino-cli/dev/CONTRIBUTING/#pull-request-checklist
There was a problem hiding this comment.
We should really start thinking about putting some of the modules under the internal package, the cli module is one that doesn't have much use outside the arduino-cli.
cmaglie
requested changes
Nov 29, 2021
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
2 times, most recently
from
0bdd20b
to
2ea50f3
Compare
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
from
2ea50f3
to
ed0f442
Compare
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
from
ed0f442
to
821d048
Compare
per1234
requested changes
Dec 15, 2021
per1234
approved these changes
Dec 15, 2021
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
from
0f82574
to
f28f0d3
Compare
umbynos
changed the title
core operations, improving on the user input
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
from
f28f0d3
to
375aa2c
Compare
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
2 times, most recently
from
cbaed7f
to
96b8f31
Compare
silvanocerza
approved these changes
Dec 21, 2021
using the `core.GetPlatform()` approach
…y use the same piece of logic (`ParseReference()`)
Co-authored-by: per1234 <accounts@perglass.com>
…ring the user is trying to operate matches perfectly one of the available platforms, optimize the code
umbynos
force-pushed
the
umbynos/case_insensitive_package_platform
branch
from
96b8f31
to
3849a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Feature
installing / uninstalling / upgrading / downloading cores is not case insesitive
now it is's case-insensitive, so it works if you try to
core install Arduino:samdtitled accordingly?
no
See how to contribute