Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lib upgrade trying to upgrade core bundled libraries #1580

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Fix lib upgrade trying to upgrade core bundled libraries #1580

merged 1 commit into from
Dec 3, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

lib upgrade command tries to upgrade libraries bundled with cores.

  • What is the new behavior?

lib upgrade doesn't try to upgrade libraries bundled with cores anymore.

Nope.

  • Other information:

Fixes #1516.

See how to contribute

@silvanocerza silvanocerza added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 2, 2021
@silvanocerza silvanocerza self-assigned this Dec 2, 2021
@silvanocerza silvanocerza merged commit c5fe48d into master Dec 3, 2021
@silvanocerza silvanocerza deleted the scerza/fix-lib-upgrade branch December 3, 2021 11:15
umbynos pushed a commit that referenced this pull request Dec 7, 2021
@silvanocerza @umbynos
Fix lib upgrade trying to upgrade core bundled libraries (#1580)
648039f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

@per1234 per1234 Awaiting requested review from per1234

Assignees

@silvanocerza silvanocerza

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arduino-cli lib upgrade (re-)installs the same libraries multiple times
2 participants
@silvanocerza @umbynos