Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: apply monitor settings on monitor opening #1604

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Bugfix: apply monitor settings on monitor opening #1604

merged 1 commit into from
Dec 23, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 23, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    The arduino-cli monitor -c .... flag wasn't working, this PR fix the problem
  • What is the current behavior?
    Port settings are not applied.
  • What is the new behavior?
    Port settings are applied.

@cmaglie cmaglie requested a review from a team December 23, 2021 15:04
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 23, 2021
@cmaglie cmaglie merged commit 12adc53 into arduino:master Dec 23, 2021
@cmaglie cmaglie deleted the fix_monitor_setting branch December 23, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

monitor does not apply serial port configuration change like baudrate
3 participants
@cmaglie @silvanocerza @per1234