Improved pluggable discovery conversion for platforms not supporting it #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms may add information through the optional config part of the FQBN (platforms menu items).
silvanocerza
approved these changes
Jan 19, 2022
|
I had a (late) look at this PR, looks good to me, no comments. I've also tested it in my local setup, and it indeed fixes #1444 for me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Improves the automatic conversion of platforms to keep backward compatibility after the introduction of pluggable-discovery.
What is the current behavior?
If a platform defines
upload.toolsin the configuration part of theboars.txt(typically in themenu.*.*.upload.toolproperties), the upload will fail because the properties under themenu.*hierarchy are not converted.What is the new behavior?
The properties are now converted.
Does this PR introduce a breaking change, and is titled accordingly?
No
Fix #1444