Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Install pluggable monitor dependencies together with a platform #1637

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 24, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Fixed a bug that prevented pluggable monitors to be installed

What is the current behavior?
non-builtin pluggable monitors are not installed (see #1564)

What is the new behavior?
non-builtin pluggable monitors are now installed

Does this PR introduce a breaking change, and is titled accordingly?
No breaking changes

@cmaglie cmaglie requested a review from a team January 24, 2022 18:54
@cmaglie cmaglie self-assigned this Jan 24, 2022
@cmaglie cmaglie linked an issue Jan 24, 2022 that may be closed by this pull request
@cmaglie cmaglie added criticality: high Of high impact topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project labels Jan 24, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1564 for me.
Thanks Cristian!

@per1234 per1234 added the topic: code Related to content of the project itself label Jan 25, 2022
@cmaglie cmaglie merged commit 98f795d into arduino:master Jan 25, 2022
@cmaglie cmaglie deleted the install_monitor_deps branch January 25, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: high Of high impact topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitorDependencies are not installed with platform
3 participants