Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error logging for pluggable monitors / Fixed resource leak in some rare conditions #1638

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Improved error logging for pluggable monitors / Fixed resource leak in some rare conditions #1638

merged 2 commits into from
Jan 28, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 25, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

  • Added more logging for pluggable monitor
  • Force monitor close if the port cannot be opened (fix resource leak)

Does this PR introduce a breaking change, and is titled accordingly?
no breaking change

@cmaglie cmaglie mentioned this pull request Jan 25, 2022
Closed
@cmaglie cmaglie self-assigned this Jan 25, 2022
@cmaglie cmaglie requested a review from a team January 28, 2022 14:44
@cmaglie cmaglie changed the title Improved error logging for pluggable monitors Improved error logging for pluggable monitors / Fixed resource leak in some rare conditions Jan 28, 2022
@cmaglie cmaglie merged commit 1b0c127 into arduino:master Jan 28, 2022
@cmaglie cmaglie deleted the better_errors_plug_mon branch January 28, 2022 14:54
@cmaglie cmaglie added priority: medium Resolution is a medium priority topic: CLI Related to the command line interface type: enhancement Proposed improvement labels Jan 28, 2022
@cmaglie cmaglie added this to the arduino-cli 0.21.0 milestone Jan 28, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees

@cmaglie cmaglie

Labels
priority: medium Resolution is a medium priority topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
arduino-cli 0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmaglie @silvanocerza @per1234