Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Remove broken download stats workflow #1701

Merged
merged 1 commit into from Apr 1, 2022
Merged

[skip changelog] Remove broken download stats workflow #1701

merged 1 commit into from Apr 1, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Apr 1, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?

The "arduino-stats" GitHub Actions workflow was designed to periodically gather download statistics from Arduino's CDN and push them to Datadog.

The recorded stats showed a periodic decrease in total download count. Since this is patently impossible, it is clear that something was wrong with the system and that the recorded data was not usable. An investigation into the problem was never done.

On 2022-03-14, the runs of the "arduino-stats" GitHub Actions workflow began to fail:

Traceback (most recent call last):
  File "/home/runner/work/arduino-cli/arduino-cli/.github/tools/fetch_athena_stats.py", line 131, in <module>
    exec_id = execute(athena_client, query, DEST_S3_OUTPUT)
  File "/home/runner/work/arduino-cli/arduino-cli/.github/tools/fetch_athena_stats.py", line 27, in execute
    wait_for_query_execution_completion(client, execution_id)
  File "/home/runner/work/arduino-cli/arduino-cli/.github/tools/fetch_athena_stats.py", line [40](https://github.com/arduino/arduino-cli/runs/5539443430?check_suite_focus=true#step:4:40), in wait_for_query_execution_completion
    raise BaseException(
BaseException: query failed or canceled: INVALID_FUNCTION_ARGUMENT: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "b "

Because there had not been any relevant change in the repository between the last successful run and the first failing run, it seems likely that some external change caused the breakage.

  • What is the new behavior?

Since the workflow was not ever working successfully and the lack of an investigation about that indicates that the stats are not of immediate importance, the best course of action is to simply remove the broken infrastructure from the repository rather than investing time into fixing something that isn't being used anyway.

No breaking change

The "arduino-stats" GitHub Actions workflow was designed to periodically gather download statistics from Arduino CDN and
push results to Datadog.

The recorded stats showed a periodic decrease in total download count. Since this is patently impossible, it is clear
that something was wrong with the system and that the recorded data was not usable. An investigation into the problem
was never done.

On 2022-03-14, the runs of the "arduino-stats" GitHub Actions workflow began to fail. Because there had not been any
relevant change in the repository between the last successful run and the first failing run, it seems that some external
change caused the breakage. Since the workflow was not ever working successfully and the lack of an investigation about
that indicates that the stats are not of immediate importance, the best course of action is to simply remove the broken
infrastructure from the repository rather than investing time into fixing something that isn't being used anyway.
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Apr 1, 2022
@per1234 per1234 requested a review from umbynos April 1, 2022 12:29
@per1234 per1234 self-assigned this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants