Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Migrate tests from test_compile_part_3.py to compile_part_3_test.go #1906

Merged
merged 10 commits into from
Oct 13, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_compile_part_3.py have been rewritten in compile_part_3_test.go, without changing their original purpose.
More informations on the tests can be found checking the single commits.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 5, 2022
@MatteoPologruto MatteoPologruto self-assigned this Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 36.84% // Head: 0.00% // Decreases project coverage by -36.84% ⚠️

Coverage data is based on head (08d25b5) compared to base (fb9d4a8).
Patch has no changes to coverable lines.

❗ Current head 08d25b5 differs from pull request most recent head 8a8df2b. Consider uploading reports for the commit 8a8df2b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1906       +/-   ##
==========================================
- Coverage   36.84%       0   -36.85%     
==========================================
  Files         235       0      -235     
  Lines       19763       0    -19763     
==========================================
- Hits         7282       0     -7282     
+ Misses      11650       0    -11650     
+ Partials      831       0      -831     
Flag Coverage Δ
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go
legacy/builder/builder.go
...der/wipeout_build_path_if_build_options_changed.go
commands/lib/utils.go
executils/null.go
arduino/security/signatures.go
commands/upgrade/upgrade.go
cli/generatedocs/generatedocs.go
configuration/defaults.go
legacy/builder/container_setup.go
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes

@MatteoPologruto
Copy link
Contributor Author

MatteoPologruto commented Oct 11, 2022

I've rearranged some tests following PR #1913. I left the ones that are not using arduino:avr as a core and the ones that are modifying either boards.local.txt or platform.local.txt in compile_part_3_test.go.

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@MatteoPologruto MatteoPologruto merged commit c48844b into arduino:master Oct 13, 2022
@MatteoPologruto MatteoPologruto deleted the compile-3 branch October 13, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants