[breaking] Fix board attach CLI command, and remove gRPC API

[silvanocerza]

Please check if the PR fulfills these requirements

See how to contribute

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• The PR follows
  our contributing guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Remove an unused neglected broken feature.

What is the current behavior?

board attach CLI command and BoardAttach gRPC interface command are both broken and neglected. Their behaviour is unclear and buggy.

What is the new behavior?

Remove board attach CLI command and BoardAttach gRPC interface command and all their usages from the project.

Does this PR introduce a breaking change, and is titled accordingly?

Yes and yes.

Other information

Closes #1925.

[cmaglie]

• There is this test to remove:

    board_test.go:452: 
        	Error Trace:	/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/board/board_test.go:452
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestBoardAttachWithoutSketchJson
--- FAIL: TestBoardAttachWithoutSketchJson (2.50s)

• you must run a go mod tidy on all sub-projects to fix all the internal go.mod/go.sum
• thinking about go.mod, we should also be able to get rid of this dependency: github.com/arduino/board-discovery so running a go mod tidy on the main repo should show it.

[cmaglie]

Ah you already did it most of it, LOL. I should reload the page before starting a review :-)

[silvanocerza]

Ah you already did it most of it, LOL. I should reload the page before starting a review :-)

I just pushed it really, you would have missed it in any case. 😅

By the way not sure about the sketch.json, the Sketch specifications docs still mention it and I didn't check other commands to see if it's still in use.

Regarding go mod tidy I found out that commands/daemon/term_example has a go.sum but no go.mod, so running it there fixes the root one.
It's also checked in CI check-outdated job, see this, but that's like checking root two times.

[cmaglie]

Regarding go mod tidy I found out that commands/daemon/term_example has a go.sum but no go.mod, so running it there fixes the root one.

I see, I think I forgot to commit the go.mod too, BTW since the example do not use any external library I think we can remove the extra go.sum and the check from the workflow.

[silvanocerza]

I see dependencies checks are failing but I can't manage to run licensed locally. Would be great if someone could do it. <3

[per1234]

Here you go Silvano: silvanocerza#5

[silvanocerza]

Thanks @per1234, greatly appreciated. :)

[umbynos]

Hello @silvanocerza, thanks a lot for this PR! Today with @per1234 @ubidefeo @cmaglie we spoke about this. In the end we decided to not completely deprecate the command, mainly because the users are using this and overall it only needs some love.
To summarize what we discussed:

• drop the current implementation of the board attach cli command (done already in this PR)
• the cli will still use the same sketch.json file for saving metadata
• the board attach command now has to accept 3 flags --fqbn, --port, and optionally --protocol (regarding this there should already be all the helper functions in cli/arguments.

[silvanocerza]

Sorry, no time to completely rework the command like that.
Feel free to keep working on this PR though.

[cmaglie]

I've pushed the implementation, but now I have my own review pending... I can approve the my changes by myself but doesn't look like a good plan mmmmmhhhh...

Take ownership of this PR