Fix empty copy of compiled binaries when --build-path equals to --output-dir
#2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alessio-perugini
changed the title
alessio-perugini
added
topic: code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2320 +/- ##
=======================================
Coverage 63.03% 63.04%
=======================================
Files 200 200
Lines 19206 19202 -4
=======================================
- Hits 12106 12105 -1
+ Misses 6053 6051 -2
+ Partials 1047 1046 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
fix-conflict--build-path-with--output-dit-when-compiling
branch
2 times, most recently
from
5079255
to
2093d01
Compare
alessio-perugini
changed the title
--build-path equals to --output-dir
alessio-perugini
requested review from
cmaglie,
umbynos and
MatteoPologruto
alessio-perugini
force-pushed
the
bye_bye_legacy
branch
2 times, most recently
from
9c073c1
to
99ccfb5
Compare
cmaglie
force-pushed
the
bye_bye_legacy
branch
from
99ccfb5
to
4e1afd1
Compare
alessio-perugini
force-pushed
the
fix-conflict--build-path-with--output-dit-when-compiling
branch
from
2093d01
to
068deb7
Compare
…output-dir When compiling with --output-dir pointing to the same directory of --build-path do not copy file
alessio-perugini
force-pushed
the
fix-conflict--build-path-with--output-dit-when-compiling
branch
from
068deb7
to
1b3ef43
Compare
cmaglie
approved these changes
Sep 20, 2023
alessio-perugini
deleted the
fix-conflict--build-path-with--output-dit-when-compiling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Skip the copy of compiled binaries when the specified
--build-pathequals to--output-dir.By doing so we also avoid useless computation. (This doesn't solve the root of the problem which is underneath the
CopyTofunction. Another PR will address it to go-paths-helper repo)What is the current behavior?
When
--build-pathequals to--output-dirwe copy the compiled files but their contet is empty.What is the new behavior?
When both flags are set we simply skip the copying part.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Most likely we should address this also in the gopaths library.