Library update/install with --no-overwrite will perform the update if it's possible to keep already installed dependencies at their current version
#2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
semver-improvements
branch
from
d7e6b72
to
5940923
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2431 +/- ##
==========================================
+ Coverage 67.33% 67.43% +0.10%
==========================================
Files 210 210
Lines 20567 20591 +24
==========================================
+ Hits 13849 13886 +37
+ Misses 5581 5572 -9
+ Partials 1137 1133 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie
force-pushed
the
semver-improvements
branch
2 times, most recently
from
f9eef49
to
9c14b77
Compare
cmaglie
changed the title
--no-overwrite will perform the update if it's possible to keep already installed dependencies at their current version
3 tasks
cmaglie
force-pushed
the
semver-improvements
branch
from
9c14b77
to
b352d90
Compare
Previously the --no-overwrite flag would fail to install if a library dependency was already installed but not at the latest version. After this change the already present library may be accepted as a dependency if it match the version constraints of the installed library.
cmaglie
force-pushed
the
semver-improvements
branch
from
b352d90
to
bb678e5
Compare
alessio-perugini
approved these changes
Nov 27, 2023
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
lib install --no-overwriteflags when there are already installed dependencies--no-overwriteflag tolib depsto check the solution found by the install planner.See #1799 for more details.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information