[breaking] Some gRPC API improvements #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
requested review from
kittaakos,
alessio-perugini,
umbynos and
MatteoPologruto
cmaglie
force-pushed
the
grpc-api-improements
branch
from
b58ca48
to
0305e5e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
- Coverage 67.61% 67.54% -0.08%
==========================================
Files 207 207
Lines 20710 20747 +37
==========================================
+ Hits 14003 14013 +10
- Misses 5563 5589 +26
- Partials 1144 1145 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Dec 19, 2023
kittaakos
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Add the
oneof messsage { ... }to the protobuf definition of the gRPC responses that provide a streaming output. This will make the gRPC consistent as requested in #2450.This change also fixed a weird edge case in the gRPC->result mapping in the
feedbackpackage.What is the current behavior?
No changes
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information
Fix #2450