Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Allow setting extra paths for build-cache #2612

Merged
merged 10 commits into from
May 29, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 24, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Allows to specify extra paths for build-cache to look for already build artifacts if they are not found in the default build-cache dir.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes.

Other information

Fix #2611

This change helps to better understand next commits.
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 24, 2024
@cmaglie cmaglie self-assigned this May 24, 2024
@cmaglie cmaglie changed the title [breaking] Allow setting of extra paths for build-cache [breaking] Allow setting extra paths for build-cache May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (dc13ef6) to head (8bdda04).

Files Patch % Lines
internal/arduino/builder/core.go 66.66% 9 Missing and 2 partials ⚠️
commands/service_compile.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
+ Coverage   70.26%   70.30%   +0.03%     
==========================================
  Files         222      222              
  Lines       21262    21304      +42     
==========================================
+ Hits        14940    14977      +37     
- Misses       5147     5151       +4     
- Partials     1175     1176       +1     
Flag Coverage Δ
unit 70.30% <75.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive work, good job!
Love all the combinations of flags in the integration tests!

rpc/cc/arduino/cli/commands/v1/compile.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left a single comment

internal/cli/configuration/build_cache.go Outdated Show resolved Hide resolved
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
@cmaglie cmaglie merged commit 81d517b into arduino:master May 29, 2024
104 checks passed
@cmaglie cmaglie deleted the core_cache_extra_paths branch May 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to provide multiple build cache paths during compilation.
4 participants