Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install script and update install instructions #324

Merged
merged 11 commits into from Aug 6, 2019
Merged

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 5, 2019

This PR adds an install.sh script based on the one from https://github.com/Masterminds/glide to allow newcomers to simply do:

curl https://raw.githubusercontent.com/arduino/arduino-cli/master/install.sh | sh

to install the CLI.

It also updates the README accordingly, showing the various supported install methods. The markdown was also fixed to leverage Github's rendering helpers and show a nice output in the examples.

@masci masci added topic: documentation Related to documentation for the project component/packaging labels Aug 5, 2019
@masci masci requested a review from mastrolinux August 5, 2019 16:03
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying the new installer on my macOS machine I've found two minor issues. I've proposed a bug fix on the JSON issue using the new (for me!) GitHub feature for suggesting changes.

Let me know what you think..

install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
Co-Authored-By: Maurizio Branca <maurizio.branca@gmail.com>
per1234
per1234 previously requested changes Aug 6, 2019
README.md Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
masci and others added 8 commits August 6, 2019 11:44
Co-Authored-By: Maurizio Branca <m.branca@arduino.cc>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
@per1234 per1234 dismissed their stale review August 6, 2019 11:23

The requested changes were made. Thanks!

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also on behalf of @mastrolinux :)

@masci masci merged commit bd20ce6 into master Aug 6, 2019
@masci masci deleted the massi/install branch August 6, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants