Do not hit github api to get latest version from install script #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to query the GitHub API to get the latest version of the CLI and such calls might be rate limited, specially in shared CI environments.
This PR hits the downloads page directly and
grep
s the HTML contents so no rate limit will be applied. As a side effect, we don't need Python anymore and this will make the install script more robust under Windows shells like MinGW and Msys.