Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a local Walk function #421

Merged
merged 17 commits into from
Oct 29, 2019
Merged

Use a local Walk function #421

merged 17 commits into from
Oct 29, 2019

Commits on Sep 22, 2019

  1. Use a local Walk function 

    Because arduino-cli segfaults when sketchDir is a symbolic link, a simple
walk function is introduced with a twofold effect:
- fix the segfault
- allow to use symlinks

ref: https://www.google.com/search?q=golang+Walk+does+not+follow+symbolic+links
    @d-a-v
    d-a-v committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    94e3d7b View commit details
    Browse the repository at this point in the history

  2. tabs

    @d-a-v
    d-a-v committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    7186d73 View commit details
    Browse the repository at this point in the history

  3. style

    @d-a-v
    d-a-v committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    23f0204 View commit details
    Browse the repository at this point in the history

  4. comment

    @d-a-v
    d-a-v committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    fad3aa5 View commit details
    Browse the repository at this point in the history

  5. retrigger CI

    @d-a-v
    d-a-v committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    7403a39 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. retrigger CI

    @d-a-v
    d-a-v committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    9c82aad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:arduino/arduino-cli

    @d-a-v
    d-a-v committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    aac3d81 View commit details
    Browse the repository at this point in the history

  3. style

    @d-a-v
    d-a-v committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    38c71e9 View commit details
    Browse the repository at this point in the history

  4. check sketch for being a file

    @d-a-v
    d-a-v committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    5503c56 View commit details
    Browse the repository at this point in the history

  5. check sketch is not a directory

    @d-a-v
    d-a-v committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    75ffd4f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Merge branch 'master' of github.com:arduino/arduino-cli

    @d-a-v
    d-a-v committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    98bc2e3 View commit details
    Browse the repository at this point in the history

  2. additions: 

    - act on error in walk function (OS can detect symbolic links loops (lnk -> lnk))
- add a deepness detector for non trivial loops (dir/lnk -> ../..)
    @d-a-v
    d-a-v committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    05576c9 View commit details
    Browse the repository at this point in the history

  3. fixes from "task check"

    @d-a-v
    d-a-v committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    fe4cd8b View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. updates per review

    @d-a-v
    d-a-v committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    b51893a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. style

    @d-a-v
    d-a-v committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    cde4bec View commit details
    Browse the repository at this point in the history

  2. Update arduino/builder/sketch.go 

    Co-Authored-By: Roberto Sora <r.sora@arduino.cc>
    @d-a-v
    d-a-v and Roberto Sora committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    d41fa12 View commit details
    Browse the repository at this point in the history

  3. fixes

    @d-a-v
    d-a-v committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    9de3344 View commit details
    Browse the repository at this point in the history