Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for both .pde and .ino files when compile target is a folder #490

Merged
merged 1 commit into from Nov 28, 2019
Merged

Look for both .pde and .ino files when compile target is a folder #490

merged 1 commit into from Nov 28, 2019

Conversation

lluiscampos
Copy link
Contributor

Fixes #386

Support .pde extension by compile when only folder specified (#386)

When only specifying folder, the logic will try both <DirName>.ino and
<DirName>.pde as the main sketch file. If both are found, and error is
also thrown (it would break on compile later on).

Added couple of unit tests also.

@lluiscampos
Copy link
Contributor Author

I don't think the "Build Failed" is related to the code changes.

GitHub says:

### ERRORED 11:34:22Z

- Workflows can't be executed on this repository. Please check your payment method or billing status.

@zmoog
Copy link
Contributor

zmoog commented Nov 20, 2019

@lluiscampos no, it's not your fault, the CI system is currently disabled due to administrative problems but it'll be back online soon. 🤞

@lluiscampos
Copy link
Contributor Author

@zmoog do we have the CI system up and running? Can you manually start the pipeline for this PR?

@zmoog
Copy link
Contributor

zmoog commented Nov 22, 2019

My apologies: unfortunately t's an administrative problem, and I can't start the pipeline, I'm sorry.

AFAIK the issue should be fixed soon.

@lluiscampos lluiscampos force-pushed the support-pde-extension-when-folder branch from ebb47c7 to 5c38844 Compare November 28, 2019 11:46
@lluiscampos
Support .pde extension by compile when only folder specified (arduino…
174c49e 
…#386)

When only specifying folder, the logic will try both <DirName>.ino and
<DirName>.pde as the main sketch file. If both are found, and error is
also thrown (it would break on compile later on).

Added couple of unit tests also.

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
@lluiscampos lluiscampos force-pushed the support-pde-extension-when-folder branch from 5c38844 to 174c49e Compare November 28, 2019 12:07
@lluiscampos
Copy link
Contributor Author

@zmoog Finally, I was able to run the CI checks (which failed the first run but I amended afterwards). Let me know if I need to correct something else :)

@masci masci added this to the 0.7.0 milestone Nov 28, 2019
masci
masci approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci changed the title Support .pde extension by compile when only folder specified (#386) Look for both .pde and .ino files when compile target is a folder Nov 28, 2019
@masci
Copy link
Contributor

masci commented Nov 28, 2019

Thanks for the PR @lluiscampos!

I've modifed a bit the title because it'll be automatically added as an entry in the next CHANGELOG and I think this way it works a bit better.

@rsora rsora merged commit 0ccd608 into arduino:master Nov 28, 2019
@lluiscampos
Copy link
Contributor Author

Awesome, thanks! After many years as a user, I am very exited to have contributed to Arduino 😃

@lluiscampos lluiscampos deleted the support-pde-extension-when-folder branch June 1, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

.pde file extension not supported by compile when only folder specified
4 participants
@lluiscampos @zmoog @masci @rsora