Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip changelog] Tag CI failures with workflow name #747

Merged
merged 1 commit into from Jun 10, 2020
Merged

[skip changelog] Tag CI failures with workflow name #747

merged 1 commit into from Jun 10, 2020

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 10, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Tag failure events we send to Datadog with the workflow name so that it's easier to setup alerts.

  • Does this PR introduce a breaking change?

No changes to the CLI

  • Other information:

See how to contribute

@masci
Copy link
Contributor Author

masci commented Jun 10, 2020

Tests failure is unrelated to my changes

rsora
rsora approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a problem during the deployment of a new version of the package_index.json that caused the CI failure.
The problem is now fixed!

@masci masci merged commit d0f0288 into master Jun 10, 2020
@masci masci deleted the massi/dd branch June 10, 2020 12:21
umbynos pushed a commit that referenced this pull request Jun 17, 2020
@umbynos
tag failures with workflow name (#747)
3407ad4
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masci @rsora @per1234