Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh completion #806

Merged
merged 2 commits into from Jul 9, 2020
Merged

Fix zsh completion #806

merged 2 commits into from Jul 9, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 9, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?

Before this PR the zsh completion was not working correctly: when you tried to press key after pressing "-" you would expect to receive only the flag name and not all the description alongside the name of the flag. This PR fixes that problem.
Before:
image

  • What is the new behavior?

After:
image

  • Does this PR introduce a breaking change?

no

  • Other information:

To help the review:

  1. Checkout this branch
  2. task build
  3. ./arduino-cli completion zsh > _arduino-cli
  4. source _arduino-cli
  5. rm -f ~/.zcompdump; compinit
  6. try out the completion

See how to contribute

@ubidefeo ubidefeo self-requested a review July 9, 2020 09:24
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos umbynos merged commit b2ed18f into master Jul 9, 2020
@umbynos umbynos deleted the fix_zsh_completion branch July 9, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants