Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp32 + esp8266 conflicting tool #82

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 30, 2018

@cmaglie cmaglie added the bug label Oct 30, 2018
@cmaglie cmaglie added this to the next alpha milestone Oct 30, 2018
@cmaglie cmaglie self-assigned this Oct 30, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-21-PR82-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-21-PR82-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-21-PR82-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-21-PR82-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-21-PR82-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #82 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   47.39%   47.46%   +0.07%     
==========================================
  Files          92       92              
  Lines        4064     4066       +2     
==========================================
+ Hits         1926     1930       +4     
+ Misses       1904     1903       -1     
+ Partials      234      233       -1
Impacted Files Coverage Δ
arduino/cores/packagemanager/package_manager.go 47.45% <100%> (+0.6%) ⬆️
common/formatter/output/libraries.go 81.08% <0%> (-5.41%) ⬇️
arduino/cores/cores.go 72.83% <0%> (+2.46%) ⬆️
arduino/cores/packagemanager/install_uninstall.go 54.41% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090a50b...5e99433. Read the comment docs.

@cmaglie cmaglie merged commit c9d47b4 into arduino:master Oct 31, 2018
@cmaglie cmaglie deleted the fix_esp32_8266_conflicting_tool branch October 31, 2018 09:41
per1234 added a commit that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants