Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --run-post-install and --skip-post-install flags to upgrade command #953

Merged
merged 2 commits into from Sep 24, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Adds two flags to an existing command.
  • What is the current behavior?
    arduino-cli upgrade doesn't handle post install scripts.
  • What is the new behavior?
    User can now specify --run-post-install or --skip-post-install when running arduino-cli upgrade .
  • Does this PR introduce a breaking change?
    Nope.
  • Other information:
    None.

See how to contribute

rpc/commands/commands.proto Outdated Show resolved Hide resolved
cli/upgrade/upgrade.go Outdated Show resolved Hide resolved
commands/instances.go Show resolved Hide resolved
@silvanocerza silvanocerza force-pushed the scerza/upgrade-post-install-flags branch from 5b38d4a to 7004a0b Compare September 24, 2020 09:00
@silvanocerza silvanocerza merged commit 8c2f90a into master Sep 24, 2020
@silvanocerza silvanocerza deleted the scerza/upgrade-post-install-flags branch September 24, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants