Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save dialog when closing app without changing sketches #1274

Closed
3 tasks done
sstaub opened this issue Aug 2, 2022 · 4 comments · Fixed by #1351
Closed
3 tasks done

Save dialog when closing app without changing sketches #1274

sstaub opened this issue Aug 2, 2022 · 4 comments · Fixed by #1351
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@sstaub
Copy link

sstaub commented Aug 2, 2022

Describe the problem

The save dialog comes up when closing the app even when there are no changes in the sketch.

To reproduce

Open the app, then close immediately without any changes to the sketches.

Expected behavior

The save dialog on closing app should only appear when sketch are edited.

Arduino IDE version

Version: 2.0.0-rc9-nightly-20220802 Date: 2022-08-02T03:47:07.580Z CLI Version: 0.25.1 [436f0bb9] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.5

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@sstaub sstaub added the type: imperfection Perceived defect in any part of project label Aug 2, 2022
@kittaakos
Copy link
Contributor

Related: #1016
Breaking change: 5b486b1#diff-d75767495b70f0c6a10456f6a08ea71728c0b74709a2b697e88b9b50f6890177L65.

The current logic does not check if the document was ever touched.

@kittaakos kittaakos added the topic: code Related to content of the project itself label Aug 2, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 2, 2022

Thanks for your report @sstaub. Please confirm whether this issue is specific to new sketches, or whether you also experience it when the unchanged sketch is saved in a normal location on disk.

I can only reproduce the issue with new sketches.

Please note that Arduino IDE 2.x opens example sketches as a sketch, so the issue also occurs with those sketches (as was previously reported at #1026).

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Aug 2, 2022
@per1234 per1234 self-assigned this Aug 2, 2022
@sstaub
Copy link
Author

sstaub commented Aug 2, 2022

I can confirm that this issue is specific to new sketches. On other saved sketches it works as expected.

@per1234 per1234 removed the status: waiting for information More information must be provided before work can proceed label Aug 2, 2022
@InstantMuffin
Copy link
Contributor

Maybe in a way related to #1294?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants