#1016, #1274 Aligned the "Save your sketch" dialog behavior

[kittaakos]

Motivation

Change description

Other information

Closes #1016
Closes #1274
Closes #1026
Closes #660
Closes #1034
Closes #994

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[ubidefeo]

@kittaakos
I have found that when launching this build the automatically opened sketch is the first one listed in my Sketchbook.
The last one I had opened was an example (which I did not save, of course).
In case no previously open sketch is available to open again, it should do as IDE 1.x does: open a new Sketch

[kittaakos]

this build the automatically opened sketch is the first one listed in my Sketchbook.
In case no previously open sketch is available

@ubidefeo, but there is a sketch to open 👆 , the first one from the Sketchbook. If you delete ~/.arduinoIDE/recent-sketches.json and ~/.arduinoIDE/recentworkspace.json, the IDE2 should open a new temp sketch.

[per1234]

Describe the problem

Sketch tab becomes closable after rename.

To reproduce

1. Click the ●●● icon on the right side of the editor toolbar.
2. Select "New Tab" from the menu.
3. In the "Name for new file" field, type foo
4. Click the OK button.
   🙂 The "foo.ino" tab does not have an X icon.
5. Click the ●●● icon on the right side of the editor toolbar.
6. Select "Rename" from the menu.
7. In the "New name for file" field, type bar.ino
   🐛 The "bar.ino" tab has an X icon.

Arduino IDE version

2.0.0-rc9.2.snapshot-948a6ed (tester build for 9a2d13f)

Operating system

Windows 10

[kittaakos]

The last one I had opened was an example (which I did not save, of course).
In case no previously open sketch is available to open again, it should do as IDE 1.x does: open a new Sketch

I have tried it, and the IDE (1.x) opens the example. Steps to reproduce:

• Open IDE (1.x),
• Open an example (I picked the File > Examples > 01. Basic > AnalogReadSerial),
• Close all other sketches if you have any but the AnalogReadSerial,
• Quit the IDE (1.x),
• Open the IDE (1.x),
• You have the AnalogReadSerial sketch opened.

The IDE2 never behaved like this 👆 .

[per1234]

Describe the problem

Regression of #831

Closability of tabs for files in the src subfolder was lost.

To reproduce

1. Put this "HasSrcFolder" sketch to your sketchbook: HasSrcFolder.zip
2. Open the "HasSrcFolder" sketch in the Arduino IDE.
3. Select File > Preferences... from the Arduino IDE menus.
4. Check the box next to "☐ Show files inside Sketches".
5. Click the OK button.
6. Open the "Sketchbook" view.
7. Click on HasSrcFolder/src/InSrcFolder.cpp
   🐛 There is no X icon on the InSrcFolder.cpp tab.

Expected behavior

Tabs for files in the src subfolder are closable, as is the behavior of the IDE build from the main branch:

Arduino IDE version

2.0.0-rc9.2.snapshot-948a6ed (tester build for 9a2d13f)

Operating system

Windows 10

Additional context

See #831 for details on why closability of these files specifically is needed.

See #946 for the original code change that enabled this closability.

[ubidefeo]

@kittaakos
I checked and there's a misalignment of behaviour.
IDE 1.x still allows you to have the app open without any workspaces.
If you close the example (not quitting the IDE) so that no windows are open, once you quit the IDE and relaunch it you get a new sketch.
I think opening anything that was available at quit is a good behaviour, but if nothing was then it should not pick the first sketch from the sketchbook but rather create a new sketch

[per1234]

IDE 1.x still allows you to have the app open without any workspaces.

Is this behavior specific to macOS @ubidefeo? #487

[kittaakos]

7. In the "New name for file" field, type bar.ino
🐛 The "bar.ino" tab has an X icon.

Closability of tabs for files in the src subfolder was lost.

Thank you for the steps, Per. Both issues should be fixed now.

[per1234]

I verified that it fixes all targeted issues:

• [UI] The dirty/close decorator is broken in IDE #1034
• Inconsistent dialogs when exit would result in user data loss #1016
• Save as native file dialog pops when enabling auto-save on a temp sketch #994
• Remove **File > Close Editor** menu item #660
• Save dialog when closing app without changing sketches #1274 / Example files - ask to save even if no changes were made to them.  #1026

As well as the two problems I reported via my previous reviews:

• #1016, #1274 Aligned the "Save your sketch" dialog behavior #1351 (review)
• #1016, #1274 Aligned the "Save your sketch" dialog behavior #1351 (review)