Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling issues with Theia 1.31.1 #1720

Open
3 tasks done
kittaakos opened this issue Nov 29, 2022 · 1 comment
Open
3 tasks done

Styling issues with Theia 1.31.1 #1720

kittaakos opened this issue Nov 29, 2022 · 1 comment
Assignees
Labels
topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

This is a follow-up task of #1655.

As noted in #1655 (comment), IDE2 styling contradicts the stylings dictated by the Theia framework.

This issue should be used to track styling issues so that our designers can provide instructions on how to handle them:

From #1655 (comment):

@91volt, Theia 1.31.0 comes with changes to have better accessibility support. Here and there the Theia styles contradict IDE2 styles. In this comment, I will attach screenshots depicting which UI parts are affected. (I will periodically update the comment with new findings if any.)

Screen Shot 2022-11-09 at 10 43 59 Screen Shot 2022-11-09 at 10 44 34

From #1662 (comment):

This contextual menu icon in the sketch control toolbar seems a little off to me: Screenshot 2022-11-28 at 14 58 11

I found that adding this CSS rule would fix it:

#arduino-open-sketch-control--toolbar {
    text-align: center;
}

To reproduce

See description

Expected behavior

All styling differences are adjusted or accepted

Arduino IDE version

#1662

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: theme Related to GUI theming labels Nov 29, 2022
kittaakos pushed a commit that referenced this issue Mar 24, 2023
Ref: #1720
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 24, 2023
Ref: #1720

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 31, 2023
Ref: #1720

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
Copy link
Contributor Author

Here and there the Theia styles contradict IDE2 styles.

Fixed via #1978.

This contextual menu icon in the sketch control toolbar seems a little off to me: Screenshot 2022-11-28 at 14 58 11

I found that adding this CSS rule would fix it:

Fixed via #1901.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants