Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sketch not saving while Offline #2079

Closed
3 tasks done
fwlrichard opened this issue May 29, 2023 · 2 comments · Fixed by #2080
Closed
3 tasks done

Sketch not saving while Offline #2079

fwlrichard opened this issue May 29, 2023 · 2 comments · Fixed by #2080
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@fwlrichard
Copy link

fwlrichard commented May 29, 2023 •
edited by kittaakos
Loading

Describe the problem

Sketch not saving while dis-connected to the internet. If I'm online Sketch saves just fine.
Save_Issue

To reproduce

Disconnect form the internet. Open a new sketch and try to save File|Save.
You get Error: Could not save the sketch. Please copy your unsaved work into your favorite text editor, and restart the IDE.
Trun WIFI back on or reconnect to the internet and clicked File|Save and the Sketch saves.

Expected behavior

I would expect the Sketch to save locally regardless of being online.

Arduino IDE version

Version: 2.1.0 Date: 2023-04-19T15:31:10.185Z CLI Version: 0.32.2 Copyright © 2023 Arduino SA

Operating system

Windows

Operating system version

Windows 11 Home Version 10.0.22621 Build 22621

Additional context

Additional reports:

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@fwlrichard fwlrichard added the type: imperfection Perceived defect in any part of project label May 29, 2023
@kittaakos kittaakos self-assigned this May 30, 2023
@kittaakos kittaakos added the topic: code Related to content of the project itself label May 30, 2023
kittaakos pushed a commit that referenced this issue May 30, 2023
fix: relaxed saveAll if no Internet connection
d1843ff 
The previous logic has incorrectly bailed the save when there is no
Internet connection. The corrected logic disallows saving files if there
is no connection between the frontend and the backend.

Ref: cff2c95
Closes #2079

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue May 30, 2023
Merged
4 tasks
@kittaakos

This comment was marked as off-topic.

Sign in to view
@kittaakos kittaakos mentioned this issue May 30, 2023
Closed
3 tasks
@kittaakos
Copy link
Contributor

@fwlrichard, thank you for taking the time and reporting the issue to us. I have created a PR with the proposed fixes: #2080. If you are willing to help us with the verification, please follow the beta-testing documentation.

kittaakos pushed a commit that referenced this issue Jun 8, 2023
@kittaakos
fix: relaxed saveAll if no Internet connection
4af488b 
The previous logic has incorrectly bailed the save when there is no
Internet connection. The corrected logic disallows saving files if there
is no connection between the frontend and the backend.

Ref: cff2c95
Closes #2079

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Jun 8, 2023
@per1234 per1234 mentioned this issue Jul 17, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: relaxed saveAll if no Internet connection arduino/arduino-ide
2 participants
@kittaakos @fwlrichard