Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library manager list search incomplete #716

Closed
sellensr opened this issue Dec 22, 2021 · 2 comments · Fixed by #1361
Closed

Library manager list search incomplete #716

sellensr opened this issue Dec 22, 2021 · 2 comments · Fixed by #1361
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@sellensr
Copy link

Describe the bug
Library manager doesn't return a list of all matching libraries

To Reproduce

  1. Go to Library Manager
  2. type "Time" in the search bar
  3. Scroll down to find Time by Michael Margolis
  4. See that it is not listed
  5. type "Margolis" and get no results at all
  6. type "timekeeping" or "GPS" and the library is found

Expected behavior
Library should be listed under all keywords

Desktop (please complete the following information):

  • OS: Mac Monterey and Big Sur
  • Version: 2.0.0 rc2 and rc3
@sellensr sellensr added the type: imperfection Perceived defect in any part of project label Dec 22, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 23, 2021
@per1234
Copy link
Contributor

per1234 commented Jun 23, 2022

Thanks so much for reporting this serious bug @sellensr.

Even though this report came first, there is now a duplicate issue that provides a bit more information on the subject: #1106

It is best to have only a single issue per subject so we can consolidate all relevant discussion to one place, so I'll go ahead and close this in favor of the other.

If you end up with additional information to share, feel free to comment in the other thread.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2022
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Jun 23, 2022
@per1234 per1234 removed the conclusion: duplicate Has already been submitted label Aug 30, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 30, 2022

After looking more closely at #1106, I realized that, although closely related, it was not really a duplicate after all.

This issue is about the search results being incomplete, which will be fixed by #1361

#1106 is more focused on a proposal to sort the Library Manager results by relevance. That sorting would have mitigated the problem of the results being incomplete, since it would have made it more likely the library searched for was in the results, but it also is useful even after Library Manager is fixed to show all the results.

@per1234 per1234 reopened this Aug 30, 2022
@per1234 per1234 linked a pull request Aug 30, 2022 that will close this issue
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants