Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#177, #1188 Implemented filter and update all for libs/boards #1361

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Aug 27, 2022

Motivation

Change description

  • Library search is not limited, the list is virtual,
  • Can filter by Type or Topic and Type,
  • New preference for enabling/disabling Check for Updates (IDE, libs, boards are done together. The preference is available from the Theia settings UI),
  • Update all functionality for libs and boards.

Other information

Closes #177
Closes #1188

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself status: on hold Do not proceed at this time labels Aug 27, 2022
@kittaakos kittaakos marked this pull request as ready for review August 30, 2022 10:07
@kittaakos kittaakos changed the title #177 Better status filtering in Library and Boards Manager, especially for updates #177, #1188 Implemented filter and update all for libs/boards Aug 30, 2022
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues jumping out code-wise.

@davegarthsimpson davegarthsimpson removed the status: on hold Do not proceed at this time label Aug 30, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: now tracked at #1380

Since I think the benefits of the PR as it is greatly outweigh this UI glitch, I would not consider it a blocker for the merge, but thought I should report it regardless:

Describe the problem

End of list can't be reached using scrollbar when there are many search results

To reproduce

  1. Open the "Library Manager" view.
  2. Clear the "Filter your search..." field.
  3. Click and drag the scrollbar to the bottom.

🐛 The list was not scrolled anywhere near to the end. You can use the mouse wheel to scroll down to verify there are many other listings.

Expected behavior

Scrollbar can always be used to reach the end of the listings.

Arduino IDE version

2.0.0-rc9.2.snapshot-b7fc83f (tester build for c9cd17b)

Operating system

Windows

Operating system version

10

Additional context

I used the unfiltered list in the demo because it provides the most dramatic results, but it will also occur with filtered searches that provide a lot of results, such as motor.

image

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: now tracked at #1381


Since I think the benefits of the PR as it is greatly outweigh this UI glitch, I would not consider it a blocker for the merge, but thought I should report it regardless:

Describe the problem

Scrollbar trails increasingly behind mouse pointer position while scrolling.

To reproduce

  1. Open the "Library Manager" view.
  2. Type servo in the "Filter your search..." field.
    This is only an arbitrary example of a common search query that might return in enough results to require scrolling.
  3. Click and drag the scrollbar downwards.

🐛 The position of the scrollbar trails increasingly behind the mouse pointer position. If the Arduino IDE window is near the bottom of the screen, it may even become necessary to stop and "grab" the bar once more in order to move it all the way to the bottom position.

image

Expected behavior

Scrollbar position always matches mouse pointer position.

Arduino IDE version

2.0.0-rc9.2.snapshot-9f3d8d9 (tester build for 41fc14c)

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working nicely for me.

Thanks so much for your work on this important advancement Akos and Francesco!

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

LGTM

@per1234 per1234 linked an issue Aug 30, 2022 that may be closed by this pull request
Closes arduino#177
Closes arduino#1188

Co-authored-by: Francesco Spissu <f.spissu@arduino.cc>
Co-authored-by: Per Tillisch <p.tillisch@arduino.cc>
Co-authored-by: Akos Kitta <a.kitta@arduino.cc>

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
5 participants