Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): corrected the module for tr and ru #2202

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(i18n): corrected the module for tr and ru #2202

merged 1 commit into from
Aug 31, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

The Turkish and Russian translations are missing from IDE2. This PR adds them.

Before:
Turkish:
Screenshot 2023-08-30 at 10 14 42

Russian:
Screenshot 2023-08-30 at 10 14 56

After:

Turkish:
Screenshot 2023-08-30 at 10 14 14

Russian:
Screenshot 2023-08-30 at 10 13 32

Change description

To verify:

  • Open IDE2,
  • Open the Settings dialog,
  • Select the Turkish language,
  • IDE2 reloads, and
  • Assert: IDE2-specific menus (such as Sketch and Tool) are not English.
  • Repeat the steps for the Russian language.

Other information

Closes #2201

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix(i18n): corrected the module for tr and ru
076a51f 
Closes #2201

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 30, 2023
@kittaakos kittaakos requested a review from per1234 August 30, 2023 08:21
@kittaakos kittaakos self-assigned this Aug 30, 2023
per1234
per1234 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit f0704b6 into main Aug 31, 2023
33 checks passed
@kittaakos kittaakos deleted the #2201 branch August 31, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing translations in Turkish language
2 participants
@kittaakos @per1234