Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update Windows signing Cert #2452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davegarthsimpson
Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Jun 10, 2024

Motivation

We need to update our windows signing cert.

Change description

Now that our signing is hardware dependent we have no choice other than to move our windows build process to a self hosted runner. This way we can use custom signing logic together with electron-builder.

This PR:

  • avoids installing anything during the build job on windows, the self hosted runner has everything persistently preinstalled;
  • updates workflow file variables to point to our new certificate;
  • moves our windows build process to a self hosted runner;
  • adds a custom javascript script. electron-builder now delegates signing on windows to this script.

Other information

arduino/arduino-create-agent#950
arduino/arduino-cli#2599

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@davegarthsimpson davegarthsimpson marked this pull request as draft June 10, 2024 13:06
@davegarthsimpson davegarthsimpson marked this pull request as draft June 10, 2024 13:06
@davegarthsimpson davegarthsimpson force-pushed the update-windows-signing-cert branch 3 times, most recently from dd83546 to b1607cd Compare June 29, 2024 08:19
@davegarthsimpson davegarthsimpson marked this pull request as ready for review June 29, 2024 08:20
@davegarthsimpson davegarthsimpson marked this pull request as draft June 29, 2024 08:25
@davegarthsimpson davegarthsimpson force-pushed the update-windows-signing-cert branch 8 times, most recently from ad80c61 to 5553b22 Compare July 2, 2024 09:17
@davegarthsimpson davegarthsimpson marked this pull request as ready for review July 2, 2024 09:18
@davegarthsimpson davegarthsimpson force-pushed the update-windows-signing-cert branch 2 times, most recently from 958c95b to e80f244 Compare July 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant