Staging AVR toolchain 3.6.0 (with 328pb support files) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves #46 and #36 |
|
Thank you. 👍 |
|
I have tested it under Windows with our Pro Mini PB and everything is working. PS: Could you also update the avrdude.conf with the m328PB signature. |
|
I believe this also fixes https://github.com/arduino/Arduino/issues/5286 I've been using it for the last two weeks on Windows 7 without any problems but I haven't done any extensive testing and am not using ATmega328PB. |
|
@facchinm Please do not post http links if https is available. |
|
@NicoHood you are right, sorry, link modified. |
|
How about ATmega48PB/88PB/168PB; are they added as well? Planning to add support for the whole family with MiniCore. |
|
@MCUdude the supported mcus are (attention, long list) so all the ones you mention should be there 😉 |
|
Great! So why isn't the ATmega324PB on the list? Just curious 🙂 |
|
Are there any news when the new toolchain will be used? |
PaoloP74
reviewed
Dec 6, 2017
build.conf
Outdated
| @@ -15,6 +16,10 @@ MPC_SOURCES="http://www.multiprecision.org/mpc/download" | |||
| # MPFR_VERSION=3.0.0 | |||
| # MPC_VERSION=0.9 | |||
|
|
|||
| ATMEL_ATMEGA_PACK_VERSION=1.2.132 | |||
This avoids `diff` to return != 0 and make the Jenkins script fail
This reverts commit d6fcbba.
|
You are disabling the gcc-patches code, why is that? No patches are needed anymore? If so, why not remove the last patch and let the code check for a non-empty directory? Now, there's a risk of later adding a patch again, which will not be applied. Also, a casual observer might look at this repo and expect the last patch present to be applied, which it is not. Also, the build flags are changed, and now no longer include lto. Is lto disabled now, or is it enabled by default in this gcc version? If the latter, it might be good to mention this in the commit message. I assume the commit history will get some cleanups before this is merged? |
|
@matthijskooijman it will need a cleanup for sure. LTO is enabled by default on gcc 5+ so there is no need to specify it in the config. |
|
I just installed 1.6.205 and compiled AnalogReadSerial for ATmega328B using MiniCore. Same error when using Watterott's 328PB core. It compiles fine on ATmega328P and ATmega48PB/88PB/168PB. Seems like the hardware isn't defined when compiling for 328PB. Here's the error: Output before the error occurs: Error: |
|
AnalogReadSerial compiles fine for me with Arduino AVR Boards 1.6.205, MiniCore, ATmega328PB, Arduino IDE 1.8.5, Windows 10. I wonder if it's still an macOS-specific issue like #48? The Travis CI build of MiniCore didn't have any problem compiling (other sketches) for ATmega328PB w/ Arduino AVR Boards 1.6.205 either so that indicates Linux is fine too. |
|
There's a problem at line 532-533 of https://downloads.arduino.cc/packages/package_avr_3.6.0_index.json. The filename is wrong for the arm-linux-gnueabihf version of avr-gcc 5.4.0-atmel3.6.1-arduino2. @@ -524,18 +524,18 @@
{
"name": "avr-gcc",
"version": "5.4.0-atmel3.6.1-arduino2",
"systems": [
{
"size": "30644597",
"checksum": "SHA-256:b4e2ce5c70b88d3a0f7e303a0a3cc7e5a39a96a5e7f9ea7ea0af3ccfda0f60cc",
"host": "arm-linux-gnueabihf",
- "archiveFileName": "avr-gcc-5.4.0-atmel3.6.1-arduino1-armhf-pc-linux-gnu.tar.bz2",
- "url": "http://downloads.arduino.cc/tools/avr-gcc-5.4.0-atmel3.6.1-arduino1-armhf-pc-linux-gnu.tar.bz2"
+ "archiveFileName": "avr-gcc-5.4.0-atmel3.6.1-arduino2-armhf-pc-linux-gnu.tar.bz2",
+ "url": "http://downloads.arduino.cc/tools/avr-gcc-5.4.0-atmel3.6.1-arduino2-armhf-pc-linux-gnu.tar.bz2"
},
{
"size": "31894498",
"checksum": "SHA-256:abc50137543ba73e227b4d1b8510fff50a474bacd24f2c794f852904963849f8",
"host": "i386-apple-darwin11",
"archiveFileName": "avr-gcc-5.4.0-atmel3.6.1-arduino2-i386-apple-darwin11.tar.bz2",
"url": "http://downloads.arduino.cc/tools/avr-gcc-5.4.0-atmel3.6.1-arduino2-i386-apple-darwin11.tar.bz2"
}, |
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bash magic to apply only needed files from atpack.
The file won't be downloaded automatically but must be obtained from Atmel (explicitly accepting the license).
For the braves:
the toolchains can be tested by adding
https://downloads.arduino.cc/packages/package_avr_3.6.0_index.jsonto the "Additional json" under Preferences.
This will prompt an update to avr core to version 1.6.200 (really 1.6.19 with only the new toolchain).
Please report any problem you may encounter since it has only been tested on Linux64 ATM.