Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump markdownlint-cli from 0.37.0 to 0.38.0 #432

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps markdownlint-cli from 0.37.0 to 0.38.0.

Release notes

Sourced from markdownlint-cli's releases.

0.38.0

  • Update markdownlint dependency to 0.32.1
    • Remove deprecated MD002/MD006
    • Remove rule aliases for "header"
    • Add MD054/link-image-style
    • Use micromark in MD005/MD007/MD030
    • Improve MD022/MD026/MD034/MD037/MD038/MD045/MD051
  • Remove support for end-of-life Node version 16
  • Update all dependencies via Dependabot
Commits
  • 1d2f248 Bump version 0.38.0
  • 8f3daa1 Bump ava from 6.0.0 to 6.0.1
  • aaa4119 Bump ava from 5.3.1 to 6.0.0
  • 770817b Remove support for end-of-life Node.js version 16.
  • 3e6f0dc Update tests to account for deprecation of MD002, MD006, and "header" aliases...
  • 75b959d Bump markdownlint from 0.31.1 to 0.32.1
  • 8ca31c4 Bump ignore from 5.2.4 to 5.3.0
  • d38e228 Bump actions/setup-node from 3 to 4
  • f919a81 Bump commander from 11.0.0 to 11.1.0
  • febea62 Bump glob from 10.3.7 to 10.3.10
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Dec 11, 2023
@per1234 per1234 added the type: enhancement Proposed improvement label Dec 11, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for the Node.js version 16.x used by this template was dropped by markdownlint as part of this bump: igorshubovych/markdownlint-cli@770817b

Because the engine-strict configuration is not enabled for the project, this only results in a warning:

https://github.com/arduino/tooling-project-assets/actions/runs/7166333853/job/19510157457?pr=432#step:6:8

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'markdownlint@0.32.1',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'markdownlint-cli@0.38.0',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

Even though markdownlint appears to be working fine even with the unsupported version of Node.js, I think it is best to put this bump on hold until such time as resources are available to bump Node.js to meet the requirement.

Bumps [markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli) from 0.37.0 to 0.38.0.
- [Release notes](https://github.com/igorshubovych/markdownlint-cli/releases)
- [Commits](igorshubovych/markdownlint-cli@v0.37.0...v0.38.0)

---
updated-dependencies:
- dependency-name: markdownlint-cli
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 29, 2024

Superseded by #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant