Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Call parent constructor in IconsController #1268

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix: Call parent constructor in IconsController #1268

merged 1 commit into from
Nov 29, 2021

Conversation

pboivin
Copy link
Contributor

@pboivin pboivin commented Nov 24, 2021

Description

This is a quick fix to prevent the Route [login] not defined error when visiting the /admin/icons page unauthenticated.

Note: This error may also happen with Custom CMS pages. In this case, the recommended fix would be to ensure that the custom page controller extends A17\Twill\Http\Controllers\Admin\Controller.

Related Issues

Fixes #1143

@pboivin pboivin merged commit 30c6332 into area17:2.x Nov 29, 2021
@pboivin pboivin deleted the fix/icons-controller-constructor branch November 29, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon page does not route to login correctly
2 participants