Expose the position of each related item on the loaded related items #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haringsrob
reviewed
Jun 10, 2022
|
Yes, looks awesome, @haringsrob! Feel free to put this one down. I didn't explore this at all and I was also feeling it could do good if we had access to the other related columns, so you are solving everything. Thank you! |
|
I just realise this is already in 2.8.7 https://github.com/area17/twill/blob/2.x/src/Models/Behaviors/HasRelated.php#L53 Realised that I accidentally committed it. And @pboivin already provided a fix for it as well 2411499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use the position of the related item on an application feature and this was the only way I could find to expose it, can we do this differently?