remove H5close call, introduce specific hdf5 object H5xclose calls #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been running a simdetector IOC with two instances of HDF5 plugins for a while and have not noticed any memory leaks with these changes. An example of the test run: |
|
Script used in the test: |
|
I have not tested these changes with attributes or layout XML files supplied to any plugin. |
|
Thanks for putting in the effort on this one @hinxx - its really very much appriciated!
Yikes! Good reason for this PR then 👍 From a quick glance at the changes it looks like we have consistently forgotten to close hdf5 datatype objects - and one instance of a dataspace object.
That does make it clear what paths you have tested - but we should remove those comments before merging. As a hint for the future: you can actually write these kind of comments 'inline' on the Pull Request here on github... |
|
I will test this today and if it seems to fix the problem I will merge it, removing the comments. |
I don't think so, no. I'll raise an issue for that one.
Memory leaks in error paths are probably less critical but still it would be good to eliminate. I see you have raised issue #393 to deal with that. |
That was something I spotted the first time looked around the code to find places for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial fix for memory leaks that added a call to H5close() was not proper. It caused IOC crashes if two HDF5 plugin instances were used (#390 (comment)).
This set of changes removes the call to H5close() and adds localized resource freeing that should result in no memory leaks.
I added comments to the code paths that I've seen taken (
// HK OK). Some other cases I did not test or verify (i.e. error branches) and for those the comment reads// HK test.Someone needs to go over my changes and verify the correctness.