Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned method getServicesByService() in cgi-bin/api #948

Closed
bwarden opened this issue Sep 28, 2023 · 0 comments · Fixed by #952
Closed

Orphaned method getServicesByService() in cgi-bin/api #948

bwarden opened this issue Sep 28, 2023 · 0 comments · Fixed by #952

Comments

@bwarden
Copy link
Contributor

bwarden commented Sep 28, 2023

I was just reviewing the api code and noticed that this method doesn't appear to be defined anywhere:

aredn/files/www/cgi-bin/api

Lines 431 to 432 in 48ee759

elseif comp=="byservice" then
info['pages'][page][comp]=getServicesByService()

bwarden added a commit to bwarden/aredn that referenced this issue Sep 28, 2023
@bwarden
Remove vestigial getServicesBy* methods
930d450 
getServicesByNode is only a dummy method.
getServicesByService doesn't even exist.

Remove the last remaining references to them from cgi-bin/api, and remove the last traces of getServicesByNode from aredn/olsr.lua

Fixes aredn#948
Fixes aredn#949
@bwarden bwarden mentioned this issue Sep 28, 2023
Merged
aanon4 pushed a commit that referenced this issue Sep 30, 2023
@bwarden
Remove vestigial getServicesBy* methods (#952)
a2e9e30 
* Remove vestigial getServicesBy* methods

getServicesByNode is only a dummy method.
getServicesByService doesn't even exist.

Remove the last remaining references to them from cgi-bin/api, and remove the last traces of getServicesByNode from aredn/olsr.lua

Fixes #948
Fixes #949

* Bump API version

Breaking change, removing parameters services=bynode,byservice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove vestigial getServicesBy* methods bwarden/aredn
1 participant
@bwarden