Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken method call getServicesByNode() in cgi-bin/api #949

Closed
bwarden opened this issue Sep 28, 2023 · 0 comments · Fixed by #952
Closed

Broken method call getServicesByNode() in cgi-bin/api #949

bwarden opened this issue Sep 28, 2023 · 0 comments · Fixed by #952

Comments

@bwarden
Copy link
Contributor

bwarden commented Sep 28, 2023

Reviewing the api source code, I noticed that services=bynode fails because this method isn't defined:

aredn/files/www/cgi-bin/api

Lines 429 to 430 in 48ee759

elseif comp=="bynode" then
info['pages'][page][comp]=getServicesByNode()

It looks like it just needs the aredn_olsr object, although technically that method just returns an empty dict anyway, but at least it won't result in an error and stack trace :)

 elseif comp=="bynode" then 
 	info['pages'][page][comp]=aredn_olsr.getServicesByNode() 

function model.getServicesByNode(node)
return {}
end

bwarden added a commit to bwarden/aredn that referenced this issue Sep 28, 2023
getServicesByNode is only a dummy method.
getServicesByService doesn't even exist.

Remove the last remaining references to them from cgi-bin/api, and remove the last traces of getServicesByNode from aredn/olsr.lua

Fixes aredn#948
Fixes aredn#949
@aanon4 aanon4 closed this as completed in a2e9e30 Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant