Decode and track RequestIds #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ets table for tracking request ID's.
* When generating an authn request, generate unique ID and store it for
a certain time (5 minutes).
* When validating an assertion response, verify that the ID in
`InResponseTo` (if present) matches one we know; then forget that one.
Note that both #esaml_response{} and #esaml_assertion{} gets an
`in_response_to` field: the ID is present in _both_ subtrees of the XML
document; but for validating an assertion response, only esaml_assertion
is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a certain time (5 minutes).
InResponseTo(if present) matches one we know; then forget that one.Note that both #esaml_response{} and #esaml_assertion{} gets an
in_response_tofield: the ID is present in both subtrees of the XMLdocument; but for validating an assertion response, only esaml_assertion
is used.
We chose not to add an ets table in esaml_utils and instead track the ID within our application, however this could be an option here.