Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dune to generate opam files #77

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

anuragsoni
Copy link
Contributor

No description provided.

@anuragsoni anuragsoni force-pushed the use-dune-to-generate-opam-files branch 2 times, most recently from 20279ca to 8496dea Compare April 29, 2020 01:53
@coveralls
Copy link

coveralls commented Apr 29, 2020

Coverage Status

Coverage remained the same at 68.448% when pulling 346258a on use-dune-to-generate-opam-files into 8ab0fd9 on master.

@anuragsoni anuragsoni force-pushed the use-dune-to-generate-opam-files branch from 8496dea to 7ced109 Compare April 29, 2020 02:32
Copy link
Contributor

@brendanlong brendanlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

"PGX using the standard library's Unix module for IO (synchronous)")
(depends
(ocaml
(>= 4.08))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it pick this up automatically from the pgx=version dep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. I think I forgot to remove this from here after i was done verifying that everything works. But it probably doesn't hurt to leave it in here now since we have a single file to touch during updates?

@anuragsoni anuragsoni merged commit b8a81c2 into master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants