Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJSON #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

codemasher
Copy link
Contributor

@codemasher codemasher commented Jul 12, 2015

http://gw2.chillerlan.net/examples/leaflet-maps-v2-geojson.html

However, i'm a bit unhappy with the map response. Once we get sector boundarys and maybe event data, it'd require additional features for each polyline/polygon.

@lye
Copy link
Contributor

lye commented Jul 13, 2015

I might be wrong, but I believe all map labels are actually sector or region names (including, for example, the labels on the WvW maps).

For the unlock features -- we should be able to pass the type. We can also pass the render icon URL, if there's a place to jam that in (I'm not familiar with the GeoJSON spec). I think that, in addition to dungeons, we might also be able to return vendor/tradingpost/bank/etc icon locations, but I'd have to double-check that that data isn't crazy.

I'm really not a fan of including all languages -- the way the backend servers are set up, each language is an additional request (because it has to switch languages in the same manner as the client) -- which is fairly wasteful if the application is only going to display one of them. Now that we're honoring the Accept-Language header, it should almost work automatically for browser-originated requests.

@codemasher
Copy link
Contributor Author

The map/region labels (names) are in the root of the response, while sectors are under "points_of_interest" - so we need a Feature for these in GeoJSON. You can basically put anything into a properties object. See: http://geojson.org/geojson-spec.html
NPC locations - that'd be awesome! :D

@lye
Copy link
Contributor

lye commented Jul 15, 2015

It's less NPC locations and more "where the markers for NPCs are placed on the worldmap". I believe that the marker locations are derived from the NPC locations, but I'm not entirely sure.

@codemasher
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants