Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigbee always uses software serial #7071

Closed
9 tasks
ghost opened this issue Nov 30, 2019 · 5 comments · Fixed by #7081
Closed
9 tasks

zigbee always uses software serial #7071

ghost opened this issue Nov 30, 2019 · 5 comments · Fixed by #7081
Labels
enhancement Type - Enhancement that will be worked on
Milestone

Comments

@ghost
Copy link

ghost commented Nov 30, 2019

PROBLEM DESCRIPTION

xdrv_23_zigbee_9_impl.ino calls
TasmotaSerial(pin[GPIO_ZIGBEE_RX], pin[GPIO_ZIGBEE_TX], 0, 0, 256); // set a receive buffer of 256 bytes

in line 233:
ZigbeeSerial = new TasmotaSerial(pin[GPIO_ZIGBEE_RX], pin[GPIO_ZIGBEE_TX], 0, 0, 256); // set a receive buffer of 256 bytes

This is not enabling any hardware serial lines, please see TasmotaSerial.cpp lines 82+

A clear and concise description of what the problem is.

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

  • [X ] Read the Contributing Guide and Policy and the Code of Conduct
  • [X ] Searched the problem in issues
  • [X ] Searched the problem in the wiki
  • [ X] Searched the problem in the forum
  • Searched the problem in the chat
  • [X ] Device used (e.g., Sonoff Basic): Wemos D1
  • Tasmota binary firmware version number used: _____
    • Pre-compiled
    • [ X] Self-compiled
      • IDE / Compiler used: _____
  • Flashing tools used: _____
  • Provide the output of command: Backlog Template; Module; GPIO:
    Configuration output here:
    
    
    
  • If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:
    Rules output here:
    
    
    
  • Provide the output of this command: Status 0:
    STATUS 0 output here:
    
    
    
  • Provide the output of the Console log output when you experience your issue; if applicable:
    (Please use weblog 4 for more debug information)
    Console output here:
    
    
    

TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

@s-hadinger
Copy link
Collaborator

Good catch. Are you using GPIO 1/3 or 13/15?

@ghost
Copy link
Author

ghost commented Nov 30, 2019 via email

@s-hadinger
Copy link
Collaborator

I want to find a way to have either hardware or software serial for 13/15. Automatically switching to hardware serial would preempt the serial console which is useful when debugging.

@ascillato
Copy link
Contributor

ascillato commented Nov 30, 2019

I want to find a way to have either hardware or software serial for 13/15. Automatically switching to hardware serial would preempt the serial console which is useful when debugging.

Mmm, what about being managed by the value of seriallog? If seriallog is 0 (no required info in the serial port) you can use 13/15 by hardware serial. If seriallog is >0 you have to use software serial for 13/15.

@s-hadinger
Copy link
Collaborator

Agreed. This is the best option.

@ascillato2 ascillato2 added the enhancement Type - Enhancement that will be worked on label Dec 1, 2019
s-hadinger pushed a commit to s-hadinger/Tasmota that referenced this issue Dec 1, 2019
s-hadinger pushed a commit to s-hadinger/Tasmota that referenced this issue Dec 1, 2019
s-hadinger pushed a commit to s-hadinger/Tasmota that referenced this issue Dec 1, 2019
@arendst arendst added this to the v7.1.2 milestone Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants